-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack/functions: Add functions lab. #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking nice so far. I highlighted what needs to be done in my inline comments and besides those, you should also do the following globally:
- Add a
.gitignore
file to allsupport/
andsolution/
folders. This file should only exclude the executable file and not the object file (.o
) because object files are already excluded by the.gitignore
in the root of the repo. - Take a look at the linter errors and fix them [1]. To fix the Spellcheck errors you'll also have to add the false positives (correct words flagged as incorrect because they're missing from the action's wordlist) to the wordlists here. Create a PR in which you add the new words to the corresponding files here [2]. After changing a file, run
sort -u -f <file_name.txt> <file_name.txt>
to remove duplicates. Remember to add the conjugations and declinations of each word as well as the word itself. - Squash your commits into a single one as described here [3]. For further modifications, use
git commit --amend --no-edit
to add them to the existing commit.
[1] https://github.com/cs-pub-ro/hardware-software-interface/pull/21/checks
[2] https://github.com/open-education-hub/actions/tree/main/spellcheck/config
[3] https://www.freecodecamp.org/news/git-squash-commits/
chapters/stack/functions/drills/tasks/print_rev_string/README.md
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/print_rev_string/README.md
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/print_rev_string/README.md
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/print_rev_string/README.md
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/print_rev_string/solution/print_reverse_string.asm
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/to_upper/solution/toupper.asm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increase the font of all text to 20 instead of 12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yhea, most of it is fine. Good work! I left some comments though that I'd like your input on. Feel free to disagree.
chapters/stack/functions/guides/hello_world/support/hello_world.asm
Outdated
Show resolved
Hide resolved
Oh, and one more comment: Do we need to put the content under |
Let's keep them all like this for now so all labs (with or without multiple subchapters) are consistent. It's easy to change this in the future so this isn't that big of an issue. |
chapters/stack/functions/drills/tasks/print_rev_string/solution/print_reverse_string.asm
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/string_print/solution/print_string.asm
Outdated
Show resolved
Hide resolved
chapters/stack/functions/drills/tasks/string_print/support/print_string.asm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments. Also keep in mind that i didn't comment at all files that should have changes. IT LOOKS GOOD FROM MY POINT OF VIEW.
ping @razvang0307 |
- Add functions lab based off old lab material. - Ignore throwback exercise 0. Signed-off-by: Razvan Miclius <[email protected]>
Added functions lab based off old lab material.
Ignored throwback exercise 0.
Prerequisite Checklist
Description of changes
Added the lab materials for function calls in assembly.