Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack/functions: Add functions lab. #21

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

razvang0307
Copy link

Added functions lab based off old lab material.
Ignored throwback exercise 0.

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Added the lab materials for function calls in assembly.

@razvang0307 razvang0307 added the needs-rendering The PR makes changes to the website that need to be rendered label Apr 21, 2024
Copy link

@github-actions github-actions bot added area/guides Update to guides area/tasks Update to tasks topic/stack Related to the "Stack" chapter kind/new New content / item labels Apr 22, 2024
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking nice so far. I highlighted what needs to be done in my inline comments and besides those, you should also do the following globally:

  • Add a .gitignore file to all support/ and solution/ folders. This file should only exclude the executable file and not the object file (.o) because object files are already excluded by the .gitignore in the root of the repo.
  • Take a look at the linter errors and fix them [1]. To fix the Spellcheck errors you'll also have to add the false positives (correct words flagged as incorrect because they're missing from the action's wordlist) to the wordlists here. Create a PR in which you add the new words to the corresponding files here [2]. After changing a file, run sort -u -f <file_name.txt> <file_name.txt> to remove duplicates. Remember to add the conjugations and declinations of each word as well as the word itself.
  • Squash your commits into a single one as described here [3]. For further modifications, use git commit --amend --no-edit to add them to the existing commit.

[1] https://github.com/cs-pub-ro/hardware-software-interface/pull/21/checks
[2] https://github.com/open-education-hub/actions/tree/main/spellcheck/config
[3] https://www.freecodecamp.org/news/git-squash-commits/

chapters/stack/functions/drills/tasks/to_upper/README.md Outdated Show resolved Hide resolved
chapters/stack/functions/drills/tasks/to_upper/README.md Outdated Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase the font of all text to 20 instead of 12.

chapters/stack/functions/reading/README.md Outdated Show resolved Hide resolved
Copy link

@george-cosma george-cosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yhea, most of it is fine. Good work! I left some comments though that I'd like your input on. Feel free to disagree.

chapters/stack/functions/reading/README.md Outdated Show resolved Hide resolved
chapters/stack/functions/reading/README.md Outdated Show resolved Hide resolved
chapters/stack/functions/reading/README.md Outdated Show resolved Hide resolved
chapters/stack/functions/reading/README.md Outdated Show resolved Hide resolved
chapters/stack/functions/reading/README.md Outdated Show resolved Hide resolved
@george-cosma
Copy link

george-cosma commented Apr 24, 2024

Oh, and one more comment: Do we need to put the content under Lab9/Functions/{Reading/Guides/...}. Shouldn't it be just Lab9/{Reading/Guides/...}, skip on the unnecessary sub-heading? This is a question to everyone - how do we want to handle this case?

@teodutu
Copy link

teodutu commented Apr 24, 2024

Oh, and one more comment: Do we need to put the content under Lab9/Functions/{Reading/Guides/...}. Shouldn't it be just Lab9/{Reading/Guides/...}, skip on the unnecessary sub-heading? This is a question to everyone - how do we want to handle this case?

Let's keep them all like this for now so all labs (with or without multiple subchapters) are consistent. It's easy to change this in the future so this isn't that big of an issue.

Copy link

@savacezarmarian14 savacezarmarian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. Also keep in mind that i didn't comment at all files that should have changes. IT LOOKS GOOD FROM MY POINT OF VIEW.

@valudimi valudimi added topic/memory-security Related to the "Memory Security" chapter and removed topic/memory-security Related to the "Memory Security" chapter labels May 14, 2024
@teodutu
Copy link

teodutu commented May 22, 2024

ping @razvang0307

- Add functions lab based off old lab material.
- Ignore throwback exercise 0.

Signed-off-by: Razvan Miclius <[email protected]>
@teodutu teodutu merged commit fc5b69d into cs-pub-ro:main Jan 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guides Update to guides area/tasks Update to tasks kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/stack Related to the "Stack" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants