Implementation of UI #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man kunne fjerne "Home screen" som er HVAC siden, da vi intet har med det - kode vis, men vi kunne også lade den blive, for at vise/sige at HVAC kontrollen/opkoblingen ville ske her - hvilket også stemmer nogenlunde overens med UI-design afsnittet |
mads256h
force-pushed
the
Implementation-of-UI
branch
from
6f98822 to
41311af
Compare
mads256h
requested changes
Dec 7, 2023
Co-authored-by: Mads Mogensen <[email protected]>
Co-authored-by: Mads Mogensen <[email protected]>
- _selectedTrackerMacAddress has been renamed and is now null as default (checks for this hasn't been changed - every method and class has been made private - String -> string - a list has been changed to var
… romeved and updated
mads256h
requested changes
Dec 7, 2023
Casper-NS
requested changes
Dec 7, 2023
(a half commit, so I can continue at home)
Have removed alsmost all '!' apart from the ones for _selectedTracker and _selectedWRoom at call of ConfirmEditTracker(), DeleteTrackerModal(), DeleteRoomModal(), and ConfirmEditRoom()
thom776g
force-pushed
the
Implementation-of-UI
branch
from
9175138 to
8280a63
Compare
mads256h
approved these changes
Dec 7, 2023
thom776g
force-pushed
the
Implementation-of-UI
branch
from
8280a63 to
eb4dc0d
Compare
Casper-NS
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fucky wucky