Skip to content

Commit

Permalink
Merge pull request #2518 from withbest/master
Browse files Browse the repository at this point in the history
chore: fix some comments
  • Loading branch information
montyly authored Oct 24, 2024
2 parents e659f54 + 1512fb0 commit 80c7e85
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ TEST_MODULE := tests
ALL_PY_SRCS := $(shell find $(PY_MODULE) -name '*.py') \
$(shell find test -name '*.py')

# Optionally overriden by the user, if they're using a virtual environment manager.
# Optionally overridden by the user, if they're using a virtual environment manager.
VENV ?= env

# On Windows, venv scripts/shims are under `Scripts` instead of `bin`.
Expand Down
4 changes: 2 additions & 2 deletions slither/core/declarations/function.py
Original file line number Diff line number Diff line change
Expand Up @@ -777,14 +777,14 @@ def add_explicit_base_constructor_calls_statements(self, modif: ModifierStatemen
def variables(self) -> List[LocalVariable]:
"""
Return all local variables
Include paramters and return values
Include parameters and return values
"""
return list(self._variables.values())

@property
def local_variables(self) -> List[LocalVariable]:
"""
Return all local variables (dont include paramters and return values)
Return all local variables (dont include parameters and return values)
"""
return list(set(self.variables) - set(self.returns) - set(self.parameters))

Expand Down
2 changes: 1 addition & 1 deletion slither/core/declarations/solidity_variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"abi.encodeCall()": ["bytes"],
"bytes.concat()": ["bytes"],
"string.concat()": ["string"],
# abi.decode returns an a list arbitrary types
# abi.decode returns a list arbitrary types
"abi.decode()": [],
"type(address)": [],
"type()": [], # 0.6.8 changed type(address) to type()
Expand Down
2 changes: 1 addition & 1 deletion slither/detectors/reentrancy/reentrancy.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def does_not_bring_new_info(self, new_info: "AbstractState") -> bool:

def _filter_if(node: Node) -> bool:
"""
Check if the node is a condtional node where
Check if the node is a conditional node where
there is an external call checked
Heuristic:
- The call is a IF node
Expand Down
4 changes: 2 additions & 2 deletions slither/slithir/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ def extract_tmp_call(ins: TmpCall, contract: Optional[Contract]) -> Union[Call,
# Support for library call where the parameter is a function
# We could merge this with the standard library handling
# Except that we will have some troubles with using_for
# As the type of the funciton will not match function()
# As the type of the function will not match function()
# Additionally we do not have a correct view on the parameters of the tmpcall
# At this level
#
Expand Down Expand Up @@ -1238,7 +1238,7 @@ def convert_to_low_level(
) -> Union[Send, LowLevelCall, Transfer,]:
"""
Convert to a transfer/send/or low level call
The funciton assume to receive a correct IR
The function assume to receive a correct IR
The checks must be done by the caller
Must be called after can_be_low_level
Expand Down

0 comments on commit 80c7e85

Please sign in to comment.