(WIP) cache codehash for performance #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samalws-tob
force-pushed
the
cache-codehash
branch
from
827d0e6
to
9689eec
Compare
samalws-tob
force-pushed
the
cache-codehash
branch
from
9689eec
to
40cf708
Compare
|
Ran benchmark, this removes ExtractContractMetadata from the flamegraph, just about doubles gas/second, and increases calls/second by about 50% Need to clean this up a lot, I think we can remove the cachedGethCodeHash entirely and keep only one of the gethCodeHashToCodeHash's but I'm not sure which of them to keep, should be easy enough to figure out |
samalws-tob
force-pushed
the
cache-codehash
branch
from
b6d446f
to
ffa02fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#451