Remove contrast filter in top-sponsor logos #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crystal-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ysbaddaden
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't recall the exact purpose of the contrast filter, but it really didn't have much effect in light mode, and a rather unpleasant effect in dark mode.
So the contrast filters are dropped, but instead I'm adding an updated filter for dark mode which includes an
invert()to better align the lightness for dark mode. The contrast in dark mode matches the background color of the image to the background color of the page, to achieve a transparency effect as in light mode.Dark
Before
After
Light
Before
After