ML-DSA: Work around Eurydice limitations #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eurydice can't handle associated types right now. So this changes it such that the Operations trait is implemented on top of a wrapper struct for the coefficients again. This requires the implementations of the trait to point into the struct again. But this is more self contained than propagating the generic type for the trait. I couldn't measure an impact on performance or stack size with this change
jschneider-bensch
approved these changes
Jan 8, 2025
Co-authored-by: Jonas Schneider-Bensch <[email protected]>
Co-authored-by: Jonas Schneider-Bensch <[email protected]>
|
@jschneider-bensch if you're happy with this, please merge it into #732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around limitations and drops the associated type in the operations trait.
See AeneasVerif/eurydice#125.
Eurydice can't handle associated types right now.
So this changes it such that the Operations trait is implemented
on top of a wrapper struct for the coefficients again.
This requires the implementations of the trait to point into the struct
again. But this is more self contained than propagating the generic type
for the trait.
I couldn't measure an impact on performance or stack size with this change
Note that C extraction is using slightly newer versions of the tools here. I'm not sure if that makes a difference.