Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML-DSA] Inline hash_functions.rs #701

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[ML-DSA] Inline hash_functions.rs #701

merged 3 commits into from
Dec 2, 2024

Conversation

franziskuskiefer
Copy link
Member

Adding the missig inlines to hash_functions.rs again to get back some speed.

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner November 30, 2024 16:25
@franziskuskiefer franziskuskiefer self-assigned this Nov 30, 2024
jschneider-bensch
jschneider-bensch approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks!
On my machine, I'm seeing the AVX2 versions of keygen and verification at about the same speed (or slower in the case of keygen) as the portable version, but for signing it's roughly portable = 2 * avx2 and avx2 = 2 * pqclean.

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit b2b9c4e Dec 2, 2024
53 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/mldsa-hash-inline branch December 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

Assignees

@franziskuskiefer franziskuskiefer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @jschneider-bensch