Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds impls on calls in expressions #669

Merged
merged 2 commits into from
May 15, 2024
Merged

Add bounds impls on calls in expressions #669

merged 2 commits into from
May 15, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented May 15, 2024

This PR fixes #668 by:

  • fetching impl expressions for bounds on function calls in THIR and inlining that information in the AST of hax' frontend;
  • propagate this information in the engine by adding a similar field on applications in the engine AST.

This change is required for #667, but this PR only adds the impl information internally. This PR does nothing with this information. That's why this PR doesn't add any test.

@W95Psp W95Psp marked this pull request as draft May 15, 2024 07:30
@W95Psp W95Psp changed the title Bounds impls Add bounds impls on calls in expressions May 15, 2024
@W95Psp W95Psp marked this pull request as ready for review May 15, 2024 08:01
@W95Psp W95Psp added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 1e3a524 May 15, 2024
12 checks passed
@W95Psp W95Psp deleted the bounds_impls branch May 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: THIR: Call node: missing impl_exprs for generics
2 participants