-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change order of SHA3 Scalar/Simd256 parameters #443
Conversation
Pull Request Test Coverage Report for Build 7555319057
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
We'll have to fixup kyber after this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
We'll have to fixup kyber after this change.
@mamonet looks like this is broken https://github.com/cryspen/hacl-packages/actions/runs/7211885467/job/19648338337?pr=443#step:8:233
|
I am aware of this issue, I don't seem to have hac-star generates |
What's the state here @mamonet ? Shall we wait for hacl-star/hacl-star#897 before continuing here, or do you want to get this in before? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is going through now. Let's get it in. The new functions will need tests and we need documentation on everything. But we can do that in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you didn't update your branch @mamonet. Please fix the usages.
I don't know how to add documents to headers from F* code, I will discuss this with @karthikbhargavan tomorrow and see what I can do. |
This parch updates imported SHA3-mb files to latest versions and it changes order of Scalar/Simd256 function parameters of SHA3 modes to meet the convention of original functions.