Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of SHA3 Scalar/Simd256 parameters #443

Merged
merged 8 commits into from
Jan 18, 2024

Conversation

mamonet
Copy link
Member

@mamonet mamonet commented Dec 14, 2023

This parch updates imported SHA3-mb files to latest versions and it changes order of Scalar/Simd256 function parameters of SHA3 modes to meet the convention of original functions.

@mamonet mamonet requested a review from a team as a code owner December 14, 2023 09:46
@cla-bot cla-bot bot added the cla-signed label Dec 14, 2023
@coveralls
Copy link

coveralls commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7555319057

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 57.514%

Totals Coverage Status
Change from base Build 7420995517: -1.6%
Covered Lines: 37607
Relevant Lines: 65387

💛 - Coveralls

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

We'll have to fixup kyber after this change.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

We'll have to fixup kyber after this change.

@franziskuskiefer
Copy link
Member

@mamonet looks like this is broken https://github.com/cryspen/hacl-packages/actions/runs/7211885467/job/19648338337?pr=443#step:8:233

/home/runner/work/hacl-packages/hacl-packages/pr/include/Hacl_Hash_SHA3_Simd256.h:145:3: error: unknown type name 'Lib_IntVector_Intrinsics_vec256'
  Lib_IntVector_Intrinsics_vec256 *state,

@mamonet
Copy link
Member Author

mamonet commented Dec 19, 2023

@mamonet looks like this is broken https://github.com/cryspen/hacl-packages/actions/runs/7211885467/job/19648338337?pr=443#step:8:233

/home/runner/work/hacl-packages/hacl-packages/pr/include/Hacl_Hash_SHA3_Simd256.h:145:3: error: unknown type name 'Lib_IntVector_Intrinsics_vec256'
  Lib_IntVector_Intrinsics_vec256 *state,

I am aware of this issue, I don't seem to have hac-star generates #include "libintvector.h" in a header file. I wonder if @karthikbhargavan has a clue about this. Maybe we use uint64 * instead of Lib_IntVector_Intrinsics_vec256 *!

@franziskuskiefer
Copy link
Member

What's the state here @mamonet ? Shall we wait for hacl-star/hacl-star#897 before continuing here, or do you want to get this in before?
Also not that I merged #442 such that those call sites will need to get updated before we can merge this.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is going through now. Let's get it in. The new functions will need tests and we need documentation on everything. But we can do that in a follow-up.

include/Hacl_Hash_SHA3_Scalar.h Show resolved Hide resolved
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you didn't update your branch @mamonet. Please fix the usages.

@mamonet
Copy link
Member Author

mamonet commented Jan 16, 2024

I don't know how to add documents to headers from F* code, I will discuss this with @karthikbhargavan tomorrow and see what I can do.

@franziskuskiefer franziskuskiefer merged commit ea5510b into cryspen:dev Jan 18, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants