-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Vectorized SHA3 #433
Conversation
Pull Request Test Coverage Report for Build 7084464025
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this ever test the vec256 version with 4 different inputs? If not, would be worth adding such a test , or trying with 4 different kats, 4 at a time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look much at the C code. I presume that's fine.
Generally looks good. Only a few things inline.
Also, the MSVC code appears to be missing. Please add that. The other bindings aren't too important yet as long as the CI is happy with it.
I fixed the examples on main, please cherry pick that commit or do another PR to merge main into dev first to fix that here. |
I used 4 different inputs for one shake128 vec256 test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Please run clang-format
on the cc
files. Then this is good to go. There are some types in the generated headers that we should update, but we can do that in another iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This patch imports
Hacl_SHA3_Scalar
andHacl_SHA3_Vec256
modules from hacl-starsha3-mb
branch and addssha3-mb.cc
test file to test SHA-3 modes for single-lane and 4-lanes.