Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stream-ciphers.rst #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nktrejo2020
Copy link
Contributor

Rows 1 - 138

This scheme is called :term:`ECB mode` (Electronic Code Book Mode), and it is
one of the many ways that block ciphers can be used to construct stream
The scheme is known as :term:`ECB mode` (Electronic Code Book Mode). It is
one of several methods in which block ciphers can construct stream
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate removing a passive here, but it seems kind of strange to think of a mathematical algorithm as "constructing" anything.

sufficiently large that they don't pose a practical problem.
stream of bits. Ideally, the stream should be as long as we like, but
real-world :term:`stream cipher`\s have limits. Though the stream is
sufficiently large that it does not pose practical problems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changes the meaning of the sentence. I'm not saying "it'd be great if we could get a stream of the appropriate size" because appropriate size is specific to the application of a stream cipher, i.e. the specific message you're encrypting. I'm saying that in the abstract, to evaluate a stream cipher, you'd ideally want it to produce unbounded streams. In practice they're not quite unbounded, but they're typically long enough.

Then, we'll demonstrate that attackers can often decrypt messages
The many flaws of :term:`ECB mode` are illustrated in the following two attack examples. First,
by visually inspecting an encrypted image, we exploit the fact that repeating
plaintext blocks results in repeating ciphertext blocks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gramnmar: blocks are plural, so, result?

repeating ciphertext blocks, by visually inspecting an encrypted image.
Then, we'll demonstrate that attackers can often decrypt messages
The many flaws of :term:`ECB mode` are illustrated in the following two attack examples. First,
by visually inspecting an encrypted image, we exploit the fact that repeating
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces passive voice but also changes the meaning of the sentence, I think, and it makes less sense now. You can exploit the fact that repeating plaintext blocks result in repeating ciphertext blocks through visual inspection. But it seems very strange to reverse that and say visual inspection directly you're exploiting anything.

I think this needs rephrasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants