This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: no tx-validation enclave attested TLS listener for receiving secrets from TDBE (fixes #1994) #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
tomtau
force-pushed
the
fix/inject-tve-key
branch
from
b9970ae to
b506f7c
Compare
|
bors try |
tryBuild failed: |
tomtau
force-pushed
the
fix/inject-tve-key
branch
from
b506f7c to
55046eb
Compare
|
bors retry |
tryBuild succeeded: |
tomtau
force-pushed
the
fix/inject-tve-key
branch
from
55046eb to
9cdd554
Compare
|
bors try |
tryBuild failed: |
devashishdxt
approved these changes
Aug 26, 2020
| spawn_chain_abci_thread(chain_abci_receiver, storage.clone()); | ||
| spawn_persistence_thread(persistence_receiver, storage); | ||
| // FIXME: spawn these when they actually do something | ||
| // spawn_chain_abci_thread(chain_abci_receiver, storage.clone()); |
There was a problem hiding this comment.
Why is chain_abci_thread removed? Isn't it supposed to spawn a new thread?
There was a problem hiding this comment.
it's not removed, it's commented out, as it's unused in this step
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
- Coverage 59.44% 55.56% -3.88%
==========================================
Files 223 217 -6
Lines 31935 31382 -553
Branches 10717 10763 +46
==========================================
- Hits 18983 17437 -1546
- Misses 12597 13291 +694
- Partials 355 654 +299
|
… secrets from TDBE (fixes crypto-com#1994) Solution: made parts of TDBE helpers reusable + a simple listening for mock key being pushed by incomplete TDBE enclave code (launched in chain-abci) + build modifications
tomtau
force-pushed
the
fix/inject-tve-key
branch
from
9cdd554 to
5d5d593
Compare
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: made parts of TDBE helpers reusable + a simple listening for mock key being pushed
by incomplete TDBE enclave code (launched in chain-abci) + build modifications