Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes faulty post-processing of table and figure captions in Word #595

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

crsh
Copy link
Owner

@crsh crsh commented Sep 25, 2024

This should address the more recent changes in the pandoc AST. Fixes #594, #582, and #585.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (c045234) to head (64494e8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files          46       46           
  Lines        4318     4318           
=======================================
  Hits         3494     3494           
  Misses        824      824           
Flag Coverage Δ
80.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusbarth
Copy link
Collaborator

I can confirm that the missing table numbering as described in #594 is fixed after installing from the feature branch (and updating rmdfiltr, dunno if this is important).

The problem with cross-referencing of appendices (e.g., "Appendix 1") persists. I will open a separate issue for this one.

Copy link
Collaborator

@mariusbarth mariusbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I cannot give any reasonable feedback at the lua level.

@crsh
Copy link
Owner Author

crsh commented Oct 7, 2024

Awesome, thanks!

@crsh crsh merged commit cd34c78 into main Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables not numbered when knitting to word
3 participants