feat: reward user endpoint retry mechanism #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or2e
reviewed
Mar 18, 2024
or2e
reviewed
Mar 18, 2024
or2e
previously approved these changes
Mar 20, 2024
namidaka
requested changes
Mar 20, 2024
src/Persistence/Migrations/20240318113705_AddIdempotencyKeys.cs
Outdated
Show resolved
Hide resolved
src/Persistence/Migrations/20240318113705_AddIdempotencyKeys.cs
Outdated
Show resolved
Hide resolved
src/Persistence/Migrations/20240318113705_AddIdempotencyKeys.cs
Outdated
Show resolved
Hide resolved
Comment on lines
23
to
25
|
|
||
| namespace Crpg.Persistence.Migrations | ||
| { |
Comment on lines
21
to
22
|
|
||
| #nullable disable |
|
Just passing by 👋 That can also be resolved by catching |
…into idempotency-check
namidaka
requested changes
Mar 31, 2024
Comment on lines
113
to
121
| private async Task<IdempotencyKey?> LoadIdempotencyKey(Guid key, CancellationToken cancellationToken) | ||
| { | ||
| var idempotencyKey = await _db.IdempotencyKeys | ||
| .Where(ik => ik.Key == key.ToString()) | ||
| .FirstOrDefaultAsync(cancellationToken); | ||
|
|
||
| return idempotencyKey; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please move this to the main function. There is no reuse of this method. It just makes it harder to spot issues in the main method.
|
Can you also fix the multiple warnings you introduced? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates idempotencykey table with guid, created timestamp & status.
if key doesn't exist or status != completed, will retry the reward.
else returns no reward