Enhancement: ability to set the content type on served ban template. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3cft
changed the title
| end | ||
| end | ||
| if content_type_ok == false then | ||
| ngx.log(ngx.ERR, "RET_CONTENT_TYPE '" .. content_type .. "' is not supported, using default content_type " .. M.content_type) |
There was a problem hiding this comment.
Sorry for such a long wait time, should this be BAN_CONTENT_TYPE instead of RET_CONTENT_TYPE? so they know which property in configuration is wrong?
buixor
reviewed
Aug 23, 2024
| M.HTTP_CODE["403"] = ngx.HTTP_FORBIDDEN | ||
| M.HTTP_CODE["404"] = ngx.HTTP_NOT_FOUND | ||
| M.HTTP_CODE["405"] = ngx.HTTP_NOT_ALLOWED | ||
| M.HTTP_CODE["406"] = ngx.HTTP_NOT_ACCEPTABLE | ||
| M.HTTP_CODE["500"] = ngx.HTTP_INTERNAL_SERVER_ERROR | ||
|
|
||
| M.CONTENT_TYPE = {} |
There was a problem hiding this comment.
I'm very sorry for the very late review. Is there any reason not to allow users to set content-type directly? I'm afraid the mapping is more error-prone than anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config to allow setting the content type for the banned response.
Should you wish to, for instance sending a plain/text response or just an image.
Set a valid default of
text/htmlso that any existing configs will not be broken by the change.Validate the content types against a list of permitted types.
Additionally removed duplicated
401status definition.Some whitespace changes introduced by editor (even though I tried to stop it).