Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: gocritic/typeDefFirst (ensure type definitions come before methods) #3404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 16, 2025

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Jan 16, 2025
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (ff9b350) to head (951840e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3404   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         358      358           
  Lines       38412    38412           
=======================================
  Hits        22791    22791           
  Misses      13730    13730           
  Partials     1891     1891           
Flag Coverage Δ
bats 42.26% <ø> (+0.03%) ⬆️
unit-linux 33.18% <ø> (ø)
unit-windows 28.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the lint-typedeffirst branch from c54e15d to 951840e Compare January 20, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant