enhancement: strictexpand notification template

[LaurenceJJones]

fix: #2923

We expand the environment variables as we load the plugin yaml instead of only expanding it before we send it to the plugin (which means the broker doesnt know if there are any variables in the format template).

[github-actions]

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind refactoring
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[LaurenceJJones]

/kind enhancement
/area agent

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (4748720) to head (6382395).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/csplugin/broker.go	57.14%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3377      +/-   ##
==========================================
- Coverage   58.48%   58.46%   -0.02%     
==========================================
  Files         352      352              
  Lines       37859    37864       +5     
==========================================
- Hits        22140    22138       -2     
- Misses      13810    13814       +4     
- Partials     1909     1912       +3     

Flag	Coverage Δ
bats	41.30% <57.14%> (+0.01%)	⬆️
unit-linux	34.44% <57.14%> (+<0.01%)	⬆️
unit-windows	29.69% <57.14%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.