Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: improved hub management #3352

Merged
merged 20 commits into from
Dec 26, 2024
Merged

cscli: improved hub management #3352

merged 20 commits into from
Dec 26, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 3, 2024

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Dec 3, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 68.92596% with 298 lines in your changes missing coverage. Please review.

Project coverage is 58.56%. Comparing base (466f39b) to head (707d3b5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/cliitem/metrics_table.go 14.00% 41 Missing and 2 partials ⚠️
pkg/cwhub/fetch.go 37.70% 34 Missing and 4 partials ⚠️
pkg/hubops/enable.go 52.94% 21 Missing and 11 partials ⚠️
cmd/crowdsec-cli/cliitem/item.go 72.47% 18 Missing and 12 partials ⚠️
pkg/hubops/disable.go 58.90% 20 Missing and 10 partials ⚠️
pkg/hubops/plan.go 81.20% 22 Missing and 3 partials ⚠️
pkg/hubops/download.go 83.59% 14 Missing and 7 partials ⚠️
pkg/hubops/purge.go 65.30% 12 Missing and 5 partials ⚠️
cmd/crowdsec-cli/cliitem/inspect.go 61.11% 10 Missing and 4 partials ⚠️
pkg/hubops/datarefresh.go 68.42% 8 Missing and 4 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3352      +/-   ##
==========================================
+ Coverage   58.51%   58.56%   +0.04%     
==========================================
  Files         352      357       +5     
  Lines       37893    38170     +277     
==========================================
+ Hits        22174    22354     +180     
- Misses      13810    13899      +89     
- Partials     1909     1917       +8     
Flag Coverage Δ
bats 41.60% <68.92%> (+0.20%) ⬆️
unit-linux 33.03% <3.96%> (-1.42%) ⬇️
unit-windows 28.39% <3.96%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Dec 3, 2024
@mmetc mmetc changed the title package hubops: reimplemented cscli ... install/upgrade/remove etc. new cscli hub management Dec 3, 2024
@mmetc mmetc marked this pull request as ready for review December 5, 2024 11:07
@mmetc mmetc requested review from buixor and blotus December 5, 2024 11:07
@buixor buixor added the value/high Doing this significantly improves some areas label Dec 18, 2024
@mmetc mmetc changed the title new cscli hub management cscli: improved hub management Dec 26, 2024
@mmetc mmetc merged commit a1d26bd into master Dec 26, 2024
17 checks passed
@mmetc mmetc deleted the hubops branch December 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area value/high Doing this significantly improves some areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants