Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact "cscli machines", "cscli bouncers", calls to cobra.NoArgs #3305

Closed
wants to merge 3 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 29, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Oct 29, 2024
@mmetc mmetc requested a review from sabban October 29, 2024 08:38
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 59.29919% with 302 lines in your changes missing coverage. Please review.

Project coverage is 58.24%. Comparing base (97c1f60) to head (8efc6c1).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/climachine/inspect.go 25.95% 95 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clibouncer/inspect.go 39.39% 38 Missing and 2 partials ⚠️
cmd/crowdsec-cli/climachine/add.go 66.66% 28 Missing and 10 partials ⚠️
cmd/crowdsec-cli/climachine/list.go 56.97% 35 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clibouncer/prune.go 49.15% 28 Missing and 2 partials ⚠️
cmd/crowdsec-cli/climachine/prune.go 59.70% 26 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clibouncer/list.go 67.12% 16 Missing and 8 partials ⚠️
cmd/crowdsec-cli/clibouncer/add.go 87.23% 4 Missing and 2 partials ⚠️
cmd/crowdsec-cli/climachine/validate.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
+ Coverage   58.23%   58.24%   +0.01%     
==========================================
  Files         335      346      +11     
  Lines       37397    37397              
==========================================
+ Hits        21777    21783       +6     
+ Misses      13724    13721       -3     
+ Partials     1896     1893       -3     
Flag Coverage Δ
bats 41.41% <59.29%> (+0.01%) ⬆️
unit-linux 33.97% <0.00%> (-0.03%) ⬇️
unit-windows 29.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc changed the title refact cscli: cobra.ExactArgs(0) -> cobra.NoArgs refact "cscli machines", "cscli bouncers", calls to cobra.NoArgs Oct 30, 2024
cmd/crowdsec-cli/climachine/add.go Dismissed Show dismissed Hide dismissed
@mmetc mmetc closed this Oct 30, 2024
@mmetc mmetc deleted the cobra-noargs branch October 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants