Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if resp is nil in capi metrics and continue #3299

Merged
merged 1 commit into from
Oct 25, 2024

enhance: Check if resp is nil in capi metrics and continue

691ecfb
Select commit
Loading
Failed to load commit list.
Merged

fix: Check if resp is nil in capi metrics and continue #3299

enhance: Check if resp is nil in capi metrics and continue
691ecfb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2024 in 0s

42.64% (+3.36%) compared to d8bc17b

View this Pull Request on Codecov

42.64% (+3.36%) compared to d8bc17b

Details

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.64%. Comparing base (d8bc17b) to head (691ecfb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apic_metrics.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
+ Coverage   39.27%   42.64%   +3.36%     
==========================================
  Files         480      480              
  Lines       62217    62416     +199     
==========================================
+ Hits        24437    26616    +2179     
+ Misses      35124    33144    -1980     
  Partials     2656     2656

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov