Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact pkg/database: clean up code and error messages #3263

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 25, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Sep 25, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 39 lines in your changes missing coverage. Please review.

Project coverage is 58.47%. Comparing base (ecf34c2) to head (79959e7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/database/alertfilter.go 86.53% 20 Missing and 8 partials ⚠️
pkg/database/alerts.go 0.00% 10 Missing ⚠️
pkg/types/ip.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
+ Coverage   58.45%   58.47%   +0.01%     
==========================================
  Files         351      352       +1     
  Lines       37893    37871      -22     
==========================================
- Hits        22151    22144       -7     
+ Misses      13835    13818      -17     
- Partials     1907     1909       +2     
Flag Coverage Δ
bats 41.28% <71.49%> (-0.02%) ⬇️
unit-linux 34.44% <66.66%> (+0.02%) ⬆️
unit-windows 29.67% <45.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the alert-filter branch 2 times, most recently from 356b240 to 20134c9 Compare September 25, 2024 12:56
@mmetc mmetc changed the title refact pkg/database: split filter creation, extract function refact pkg/database: clean up and improve error messages Sep 25, 2024
@mmetc mmetc changed the title refact pkg/database: clean up and improve error messages refact pkg/database: clean up code and error messages Sep 25, 2024
@mmetc mmetc force-pushed the alert-filter branch 4 times, most recently from d1bf83b to 780b0bb Compare October 2, 2024 12:41
@mmetc mmetc requested a review from blotus October 2, 2024 12:48
@mmetc mmetc marked this pull request as ready for review October 2, 2024 12:48
@mmetc mmetc force-pushed the alert-filter branch 4 times, most recently from 520a518 to 667ad51 Compare October 10, 2024 13:57
@mmetc mmetc force-pushed the alert-filter branch 3 times, most recently from a163155 to 7cf60b8 Compare October 30, 2024 10:08
@mmetc mmetc modified the milestones: 1.6.4, 1.6.5 Nov 27, 2024
@buixor buixor added the value/high Doing this significantly improves some areas label Dec 18, 2024
@buixor buixor self-assigned this Dec 18, 2024
@mmetc mmetc merged commit 26c15a1 into master Dec 19, 2024
17 checks passed
@mmetc mmetc deleted the alert-filter branch December 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactoring needs/area value/high Doing this significantly improves some areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants