Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency on docker #3175

Merged
merged 10 commits into from
Dec 18, 2024
Merged

update dependency on docker #3175

merged 10 commits into from
Dec 18, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 9, 2024

since docker doesn't have a go.mod, the opentelemetry dependencies in go.sum must be updated by hand according to the vendor.mod file of the related docker release

ex. https://github.com/docker/cli/blob/v27.1.1/vendor.mod

Copy link

github-actions bot commented Aug 9, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as draft August 9, 2024 11:16
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 64.91228% with 20 lines in your changes missing coverage. Please review.

Project coverage is 58.44%. Comparing base (b1e2b95) to head (f565efa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/docker/docker.go 71.15% 12 Missing and 3 partials ⚠️
pkg/metabase/container.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
+ Coverage   58.40%   58.44%   +0.03%     
==========================================
  Files         351      351              
  Lines       37879    37896      +17     
==========================================
+ Hits        22125    22148      +23     
+ Misses      13843    13840       -3     
+ Partials     1911     1908       -3     
Flag Coverage Δ
bats 41.30% <0.00%> (+0.03%) ⬆️
unit-linux 34.42% <64.91%> (+0.03%) ⬆️
unit-windows 29.65% <64.91%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review August 9, 2024 12:31
@mmetc mmetc marked this pull request as draft August 9, 2024 12:42
@mmetc mmetc modified the milestones: 1.6.4, 1.6.5 Oct 30, 2024
@mmetc mmetc force-pushed the dep-docker branch 2 times, most recently from 6a25b84 to e402f12 Compare November 4, 2024 12:49
@mmetc mmetc force-pushed the dep-docker branch 3 times, most recently from 89ca308 to 0fea5dd Compare December 3, 2024 22:44
@mmetc mmetc marked this pull request as ready for review December 4, 2024 07:55
@mmetc mmetc requested a review from blotus December 4, 2024 07:55
@mmetc mmetc marked this pull request as draft December 4, 2024 09:06
@mmetc mmetc marked this pull request as ready for review December 4, 2024 14:58
since docker doesn't have a go.mod, the opentelemetry dependencies
in go.sum must be updated by hand according to the vendor.mod file
of the related docker release

ex. https://github.com/docker/cli/blob/v27.1.1/vendor.mod
@buixor buixor added the value/high Doing this significantly improves some areas label Dec 18, 2024
@mmetc mmetc merged commit 99552f4 into master Dec 18, 2024
17 checks passed
@mmetc mmetc deleted the dep-docker branch December 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies needs/area value/high Doing this significantly improves some areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants