Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress progress output for crowdin file download with --no-progress #880

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

by-su
Copy link
Contributor

@by-su by-su commented Jan 9, 2025

Changes made

  • Added noProgress parameter: Allows disabling the progress display during the download process.
  • Backward Compatibility: Existing method calls remain functional as overloaded methods with default noProgress = false are provided.

How to test

To run the CLI application with the following arguments:

  1. To test FileDownload
file download locale/en.json -d ./example --no-progress
  1. To test FileDownloadTranslation
file download locale/en.json -l en -d ./example --no-progress

This closes #878

@andrii-bodnar andrii-bodnar merged commit 139bc9b into crowdin:main Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crowdin file download command ignores --no-progress option
3 participants