Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for square brackets in file paths #645

Conversation

andrecampestrini
Copy link
Contributor

@andrecampestrini andrecampestrini commented Sep 27, 2023

Added support for square brackets in translation file paths or names. Fixes #644.

@andrecampestrini andrecampestrini marked this pull request as ready for review September 27, 2023 18:13
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #645 (363683e) into main (fdf9cec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #645      +/-   ##
============================================
+ Coverage     62.62%   62.63%   +0.02%     
  Complexity     1312     1312              
============================================
  Files           200      200              
  Lines          5507     5509       +2     
  Branches        833      833              
============================================
+ Hits           3448     3450       +2     
  Misses         1613     1613              
  Partials        446      446              
Files Coverage Δ
...com/crowdin/cli/properties/helper/FileMatcher.java 81.25% <100.00%> (+2.68%) ⬆️

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@and-campestrini thanks a lot for the contribution!

@andrii-bodnar andrii-bodnar merged commit 4ff1f55 into crowdin:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving "Invalid range near index" when translation file path has square brackets
2 participants