feat(api): added endpoint for batch source string editing #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DE-dylan-lauzon
changed the title
andrii-bodnar
requested changes
Nov 14, 2024
There was a problem hiding this comment.
@DE-dylan-lauzon thank you for the contribution!
I just left a few comments, please address them.
andrii-bodnar
changed the title
Co-authored-by: Andrii Bodnar <[email protected]>
Co-authored-by: Andrii Bodnar <[email protected]>
Co-authored-by: Andrii Bodnar <[email protected]>
|
Addressed the issues noted. |
|
@DE-dylan-lauzon the CI has failed, please check the logs - https://github.com/crowdin/crowdin-api-client-php/actions/runs/11838764482/job/32990682687?pr=198 |
|
Sorry about that. CS fixer caught a couple bits of whitespace that I missed. It passes locally, now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
============================================
+ Coverage 89.36% 89.37% +0.01%
- Complexity 1293 1294 +1
============================================
Files 119 119
Lines 3390 3393 +3
============================================
+ Hits 3029 3032 +3
Misses 361 361 ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #133