feat: Add Strings Exporter Settings API #147 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faizan1191
changed the title
|
@faizan1191 could you please check the failed pipeline? Thank you! |
andrii-bodnar
added
the
hacktoberfest
|
@andrii-bodnar sure i am checking it. |
|
@andrii-bodnar just to acknowledge you I am on it and will fix this by today. |
|
@faizan1191 some Unit tests have failed, could you please take a look? |
|
@andrii-bodnar allow me sometime i will fix this by today |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
============================================
- Coverage 90.41% 90.39% -0.02%
- Complexity 1181 1201 +20
============================================
Files 107 111 +4
Lines 3076 3152 +76
============================================
+ Hits 2781 2849 +68
- Misses 295 303 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add Crowdin Strings Exporter settings API endpoints in the PHP API client.
Fixes: #147