fix: Fix AbstractTestApi::mockRequest assertions #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues in
AbstractTestApi::mockRequest
assertions and resolves the missed issues with many unit tests. Primarily the tests themselves have issues where they pass in an array butmockRequest
asserts against a json string. Additionally when a$params['response']
was unset,AbstractTestApi::mockRequest
would returnnull
which was causingPHP Notices
that the GitHub Actions configuration was hiding.There was one issue with
AbstractApi::_delete
that was detected with the fixed assertions where$params
was being passed toCrowdin::apiRequest
without being wrapped into a request$options
.Fixes #149