Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: filters and filter factory #2914

Open
wants to merge 8 commits into
base: v5
Choose a base branch
from
Open

refactor: filters and filter factory #2914

wants to merge 8 commits into from

Conversation

dennisrijsdijk
Copy link
Collaborator

Requires changes to custom-scripts-types

Description of the Change

  • Refactor event filters to typescript
  • Update filter factory
    • Allow create*Filter functions to accept a predicate for eventMetaKey
    • Allow eventMetaKey to contain property paths
    • Add createPresetFilter function to streamline filters with static or dynamic preset values
    • Add extra comparison types (eg. Doesn't Contain, Starts With, Doesn't Match Regex)
  • Move most existing filters to filter factory

Applicable Issues

#2850 Loosely Related

Testing

  • Ensured bot still starts
  • Ensured filters still properly populate inside of events
  • Tested functionality of filters that don't require monetary action and/or an affiliate channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebiggz ebiggz Awaiting requested review from ebiggz ebiggz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dennisrijsdijk