-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade crossplane-runtime to v1.17.0 #437
Open
smcavallo
wants to merge
10
commits into
crossplane:main
Choose a base branch
from
smcavallo:crossplane-runtime_v1.17.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcavallo
requested review from
ulucinar,
sergenyalcin,
erhancagirici and
mergenci
as code owners
September 11, 2024 20:08
@smcavallo Any on on when you will get an update on this? |
2 tasks
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Erhan Cagirici <[email protected]>
@smcavallo thanks for your contribution 🙏 Can you please rebase onto main? I intend to merge this PR next. |
mergenci
force-pushed
the
crossplane-runtime_v1.17.0
branch
2 times, most recently
from
December 18, 2024 12:45
b427a06
to
fc0d4e8
Compare
…ossplane#449) Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
- Compare sorted expected and observed slices. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: smcavallo <[email protected]>
mergenci
force-pushed
the
crossplane-runtime_v1.17.0
branch
from
December 27, 2024 10:28
fc0d4e8
to
524f040
Compare
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
mergenci
force-pushed
the
crossplane-runtime_v1.17.0
branch
from
December 27, 2024 10:41
524f040
to
fa20c25
Compare
3 tasks
The PR has become a mess, but I've verified that we'll be able to merge it after #451. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smcavallo [email protected]
Description of your changes
Upgrade crossplane-runtime to v1.17.0 with associated new implementations
See - https://github.com/crossplane/crossplane-runtime/releases/tag/v1.17.0
Implements
Disconnect
onExternalClient
interfaceSee - crossplane/crossplane-runtime#754
Implements
ExternalDelete
return type on methodExternalClient.Delete()
See - crossplane/crossplane-runtime#296
Upgrades go per error below:
go: module github.com/crossplane/[email protected] requires go >= 1.22.0; switching to go1.22.7
When attempting to upgrade an upjet-based provider to
v1.17.0
ofcrossplane-runtime
the below error is generated.This PR should resolve that and allow consumers to upgrade to the newer runtime.
This is a breaking change in that any consumer who uses the newer version of
upjet
will also be forced to upgrade the newer version ofcrossplane-runtime
(and also go >= 1.22.0)Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested