Add kubebuilder catagories for ProviderConfig and MyType #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added kubebuilder catagories {crossplane,provider,PROVIDER-NAME}
in the template.
Signed-off-by: Zheng Xi Zhou <[email protected]>
2 tasks
zzxwill
commented
Apr 6, 2021
| categories: | ||
| - crossplane | ||
| - provider | ||
| - PROVIDER-NAME |
There was a problem hiding this comment.
@negz @hasheddan It would be awkward if contributors copied this template and forgot to replace PROVIDER-NAME. So I wonder whether this PR is necessary.
There was a problem hiding this comment.
Hrm, I think there's a bunch of places where we assume the provider name is template and that folks will change it so this shouldn't be too bad. 🤔
There was a problem hiding this comment.
I found it useful to know which things I should change from the template. The string template is all over the place so it will be great to make it explicit that template means provider name.. which I am not 100% sure that it means that for every appearance of template. The same happens with sample in sample.template.crossplane.io
negz
reviewed
Apr 7, 2021
negz
approved these changes
Apr 7, 2021
Co-authored-by: Nic Cope <[email protected]> Signed-off-by: Zheng Xi Zhou <[email protected]>
zzxwill
force-pushed
the
kubebuilder-catagories
branch
from
dfde25d to
40d758e
Compare
Signed-off-by: Zheng Xi Zhou <[email protected] Signed-off-by: Zheng Xi Zhou <[email protected]>
zzxwill
force-pushed
the
kubebuilder-catagories
branch
from
ec03823 to
9269825
Compare
hasheddan
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added kubebuilder catagories {crossplane,provider,PROVIDER-NAME}
in the template.
Signed-off-by: Zheng Xi Zhou [email protected]
Refer to crossplane-contrib/provider-alibaba#64 (comment)