-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar!
It is great to have generated examples for all resources 👍
Apart from the comment that I've added for using acronyms, I would like us to consider putting them in generated
folder under examples
, instead of examples-generated
at the repo root.
examples-generated/accesscontextmanager/gcpuseraccessbinding.yaml
Outdated
Show resolved
Hide resolved
Thank you @turkenh. I've moved the generated examples under to |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar!
I personally wouldn't prefer to comment out all yaml given it is already mentioned to be generated and needs to be tweaked, but not a blocker.
Thanks @turkenh! |
Description of your changes
In the context of: crossplane/terrajet#48
Adds generated example manifests for the Terraform resources.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
An example generated manifest:
Corresponding Terraform registry example: