Skip to content

Commit

Permalink
chore: remove unneeded upconfig.WithBasePackages
Browse files Browse the repository at this point in the history
Signed-off-by: Marques Johansson <[email protected]>
  • Loading branch information
displague committed Jul 29, 2024
1 parent c11c09b commit caad3ab
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 17 deletions.
2 changes: 2 additions & 0 deletions apis/zz_register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 6 additions & 16 deletions config/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ func GetProvider(_ context.Context, generationProvider bool) (*upconfig.Provider
fwProvider := framework.CreateFrameworkProvider(version.ProviderVersion)

pc := upconfig.NewProvider([]byte(providerSchema), resourcePrefix, modulePath, []byte(providerMetadata),
upconfig.WithDefaultResourceOptions(
KnownReferencers(),
IdentifierAssignedByEquinix(),
SkipOptCompLateInitialization(),
LongProvision(), // TODO: use this only for Device and other long-provisioning resources
),
upconfig.WithShortName(resourcePrefix),
upconfig.WithRootGroup("equinix.jet.crossplane.io"),
upconfig.WithIncludeList([]string{
Expand All @@ -92,22 +98,6 @@ func GetProvider(_ context.Context, generationProvider bool) (*upconfig.Provider
// upconfig.WithSkipList([]string{".*"}), // helpful when debugging to minimize the number of resources
// config.WithTerraformPluginSDKIncludeList(resourceList(terraformSDKIncludeList)),
// config.WithTerraformPluginFrameworkIncludeList(resourceList(terraformPluginFrameworkExternalNameConfigs)),
upconfig.WithDefaultResourceOptions(
KnownReferencers(),
IdentifierAssignedByEquinix(),
SkipOptCompLateInitialization(),
LongProvision(), // TODO: use this only for Device and other long-provisioning resources
),
upconfig.WithBasePackages(upconfig.BasePackages{
APIVersion: []string{
// Default package for ProviderConfig APIs
"apis/v1beta1",
},
Controller: []string{
// Default package for ProviderConfig controllers
"internal/controller/providerconfig",
},
}),
)

for _, configure := range []func(provider *upconfig.Provider){
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
names:
categories:
- crossplane
- provider
- providerconfig
- equinix
kind: ProviderConfigUsage
listKind: ProviderConfigUsageList
Expand Down

0 comments on commit caad3ab

Please sign in to comment.