feat(authentication): add support for all authentification types #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacroi-m-insta
force-pushed
the
master
branch
4 times, most recently
from
42df62c to
0c34e97
Compare
dariozachow
reviewed
Sep 16, 2024
|
@lacroi-m-insta please sign off your last commit |
lacroi-m-insta
force-pushed
the
master
branch
from
a3e6f07 to
ddbad2e
Compare
I squashed my commits for a cleaner PR and left my signature. Thanks for the headsup |
Signed-off-by: Max Lacroix <[email protected]>
lacroi-m-insta
force-pushed
the
master
branch
from
3d6ebe7 to
c56e38e
Compare
dariozachow
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding support of different authentification types supported by the gitlab SDK:
BasicAuth with username and password, JobToken, OAuthToken, PersonalAccessToken that stays the default for retro-compatiability in mind.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This version is running in production.