fix: Nil panic for InsecureSkipVerify #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Blatt <[email protected]>
MisterMX
force-pushed
the
fix/insecure-nil-pointer-panic
branch
from
01372a0 to
c0460c5
Compare
janwillies
approved these changes
Feb 27, 2024
|
Successfully created backport PR #127 for |
markussiebert
pushed a commit
to markussiebert/provider-gitlab
that referenced
this pull request
Apr 8, 2024
…nil-pointer-panic fix: Nil panic for InsecureSkipVerify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes a panic due to a nil deref when using a config with
InsecureSkipVerify: true.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested