Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(group): Ignore empty resolve values in referencers #118

Conversation

MisterMX
Copy link
Collaborator

Description of your changes

Fixes #117

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@MisterMX MisterMX force-pushed the fix/group-referencer-resolve-empty branch from 64d06d3 to 5e13f5d Compare February 1, 2024 14:27
@MisterMX MisterMX requested a review from janwillies February 1, 2024 14:27
Copy link
Collaborator

@janwillies janwillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@janwillies janwillies merged commit 512c994 into crossplane-contrib:master Feb 9, 2024
7 checks passed
markussiebert pushed a commit to markussiebert/provider-gitlab that referenced this pull request Apr 8, 2024
…erencer-resolve-empty

fix(group): Ignore empty resolve values in referencers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not create groups at the basepath
2 participants