Implement Alibaba cloud SLS project #58

zzxwill · 2021-03-10T08:11:01Z

Description of your changes

Support provision Alibaba Cloud SLS project, create examples directory
for official examples and update makefile

Fixes #

I have:

Read and followed Crossplane's contribution process.
Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

wonderflow · 2021-03-10T08:31:00Z

@negz Hi, Nic, we're going to implement more cloud resources here, do you have any suggestion about the priority of cloud resources needed?

negz · 2021-03-11T00:29:34Z

Hi, Nic, we're going to implement more cloud resources here

That's great news!

do you have any suggestion about the priority of cloud resources needed?

Why don't we start an issue on this repository to gather input from users - Slack would be a great place to ask the community for input on this.

Makefile

apis/sls/v1alpha1/project_types.go

pkg/clients/sls/project.go

pkg/controller/sls/base.go

pkg/controller/sls/project_controller.go

negz · 2021-03-16T22:08:43Z

pkg/controller/sls/project_controller.go

+}
+
+func (e *external) Observe(ctx context.Context, mg resource.Managed) (managed.ExternalObservation, error) {
+	return BaseObserve(mg, e.client)


What is gained by breaking all this logic out into these separate Base functions, compared to just writing them inline?

Please kindly refer to issue #63, in which I tried to explain the reason in details and wrote a few examples.

negz · 2021-03-16T22:10:20Z

Thanks for working on this @zzxwill! Looks like a great start, but I would prefer if this managed resource was more in line with typical Crossplane conventions. If you strongly disagree with any we can discuss that and perhaps capture how provider-alibaba will diverge and why.

hack/boilerplate.go.txt

Support provision Alibaba Cloud SLS project, create `examples` directory for official examples and update makefile Signed-off-by: zzxwill <[email protected]>

Signed-off-by: zzxwill <[email protected]>

Moved copyright Year bump to crossplane-contrib#62 and examples folder changing to crossplane-contrib#61 Signed-off-by: Zheng Xi Zhou <[email protected]>

Signed-off-by: Zheng Xi Zhou <[email protected]>

negz

This is looking good @zzxwill, thank you. The main thing that still needs addressing is using meta.GetExternalName. I also wonder if we should agree on the pattern proposed in #63 before we merge this PR, but if it's urgent I could be convinced to approve while we figure out #63.

pkg/controller/sls/base.go

hongchaodeng

The code LGTM.

Please address @negz 's comments. @negz Please help approve when it is done :)

wonderflow · 2021-03-25T23:43:40Z

HI @negz Can we merge it first and fix the rest in following PRs. We need it to be merged and show in demos.

negz · 2021-03-26T20:10:33Z

HI @negz Can we merge it first and fix the rest in following PRs. We need it to be merged and show in demos.

No, sorry. I recommend building the provider from your branch if you need to use it for demos. I'm happy to merge once the remaining comments are addressed.

and wrap all errors Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill · 2021-04-05T16:43:09Z

This is looking good @zzxwill, thank you. The main thing that still needs addressing is using meta.GetExternalName.
Done. Per your suggestion, I believe SLS project name spec.froProvider.name should be deleted and the managed resource name should be regarded as the SLS project name.

I also wonder if we should agree on the pattern proposed in #63 before we merge this PR, but if it's urgent I could be convinced to approve while we figure out #63.
I will add more some examples in #63 after I talked with my colleagues which will integrated provider-base base logics.

zzxwill · 2021-04-05T16:44:59Z

@negz And I am so sorry for the late of addressing your newly two comments:) I was so busy with some other stuffs.

Signed-off-by: Zheng Xi Zhou <[email protected]>

negz · 2021-04-05T22:51:24Z

No problem @zzxwill! We've been very busy too. :) Thanks for addressing my comments about using GetExternalName and pkg/errors. It seems like there are now only two things we need to sort out to merge this:

The latest commit is failing our linter; I think one of the files needs a gofmt.
Figuring out what we are going to do about A way to extend provider-alibaba #63.

I prefer to not introduce the BaseObserve pattern in this PR until after we have a chance to discuss the context and approach in #63. How do you feel about updating this PR to use a 'normal' ExternalClient implementation for now, until we discuss further and agree?

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill · 2021-04-06T01:48:36Z

@negz Your suggestion is helpful for decomposing the problems. Addressed all of the two. Thanks help review it:)

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill · 2021-04-06T11:10:59Z

Why don't we start an issue on this repository to gather input from users - Slack would be a great place to ask the community for input on this.

Create the issue #67, and I will talk to some potential users and contributors offline first.

negz

Excellent work @zzxwill - thank you!

zzxwill force-pushed the sls branch from 76eacc0 to 46eafc0 Compare March 10, 2021 08:14

zzxwill force-pushed the sls branch from 46eafc0 to 4719049 Compare March 10, 2021 08:36

zzxwill changed the title ~~[WIP] Implement Alibaba cloud SLS project~~ Implement Alibaba cloud SLS project Mar 16, 2021

wonderflow approved these changes Mar 16, 2021

View reviewed changes

negz requested changes Mar 16, 2021

View reviewed changes

negz mentioned this pull request Mar 16, 2021

Implement OSS bucket management #59

Merged

2 tasks

zzxwill commented Mar 17, 2021

View reviewed changes

hack/boilerplate.go.txt Outdated Show resolved Hide resolved

zzxwill added 5 commits March 18, 2021 00:16

Implement Alibaba cloud SLS project

e510900

Support provision Alibaba Cloud SLS project, create `examples` directory for official examples and update makefile Signed-off-by: zzxwill <[email protected]>

Refactor code and add unit-tests

68f5e39

Signed-off-by: zzxwill <[email protected]>

Move around unrelated commits

9f20dd9

Moved copyright Year bump to crossplane-contrib#62 and examples folder changing to crossplane-contrib#61 Signed-off-by: Zheng Xi Zhou <[email protected]>

Moved GVK staff to groupversion_info.go

f562a6d

Signed-off-by: Zheng Xi Zhou <[email protected]>

Abandon klog, Reorginze spec and status

9ab7c69

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch 2 times, most recently from 9e6febb to be3d391 Compare March 17, 2021 16:29

Revert crossplane runtime version back to v0.12.0

c54ff01

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch from be3d391 to c54ff01 Compare March 17, 2021 16:30

negz reviewed Mar 23, 2021

View reviewed changes

pkg/controller/sls/base.go Outdated Show resolved Hide resolved

pkg/controller/sls/base.go Outdated Show resolved Hide resolved

hongchaodeng approved these changes Mar 24, 2021

View reviewed changes

Use meta.GetExternalName to get external resoruce name

2b650c2

and wrap all errors Signed-off-by: Zheng Xi Zhou <[email protected]>

Remove spec.forprovider.name

3c00ec7

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch from 9e6a108 to 3c00ec7 Compare April 5, 2021 16:46

fix lint problem

881491a

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch from e83b1b4 to 881491a Compare April 6, 2021 01:32

Removed BaseObserve pattern

9399724

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch from e5772cb to 9399724 Compare April 6, 2021 01:46

revert changes on Makefile on example directory

010f5bd

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch from d9cfab0 to 010f5bd Compare April 6, 2021 01:56

zzxwill added 2 commits April 6, 2021 09:58

Revert changes on hack/boilerplate.go.txt

69859cd

Signed-off-by: Zheng Xi Zhou <[email protected]>

Updated the copyright Year

077bac9

Signed-off-by: Zheng Xi Zhou <[email protected]>

zzxwill force-pushed the sls branch from f87d798 to 077bac9 Compare April 6, 2021 02:22

zzxwill mentioned this pull request Apr 6, 2021

Which cloud resource would you expect to be supported by provider alibaba? #67

Open

14 tasks

negz approved these changes Apr 6, 2021

View reviewed changes

negz merged commit 0534f02 into crossplane-contrib:master Apr 6, 2021

zzxwill deleted the sls branch April 7, 2021 01:48

zzxwill restored the sls branch April 7, 2021 01:49

zzxwill mentioned this pull request Apr 25, 2021

supply alibaba database redis #68

Closed

2 tasks

zzxwill deleted the sls branch April 25, 2021 09:25

zzxwill mentioned this pull request Jul 20, 2021

MEMBERSHIP: zzxwill crossplane/org#10

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Alibaba cloud SLS project #58

Implement Alibaba cloud SLS project #58

zzxwill commented Mar 10, 2021 •

edited

Loading

wonderflow commented Mar 10, 2021

negz commented Mar 11, 2021

negz Mar 16, 2021

zzxwill Mar 17, 2021

negz commented Mar 16, 2021

negz left a comment

hongchaodeng left a comment

wonderflow commented Mar 25, 2021

negz commented Mar 26, 2021 •

edited

Loading

zzxwill commented Apr 5, 2021

zzxwill commented Apr 5, 2021

negz commented Apr 5, 2021

zzxwill commented Apr 6, 2021

zzxwill commented Apr 6, 2021

negz left a comment

Implement Alibaba cloud SLS project #58

Implement Alibaba cloud SLS project #58

Conversation

zzxwill commented Mar 10, 2021 • edited Loading

Description of your changes

How has this code been tested

wonderflow commented Mar 10, 2021

negz commented Mar 11, 2021

negz Mar 16, 2021

Choose a reason for hiding this comment

zzxwill Mar 17, 2021

Choose a reason for hiding this comment

negz commented Mar 16, 2021

negz left a comment

Choose a reason for hiding this comment

hongchaodeng left a comment

Choose a reason for hiding this comment

wonderflow commented Mar 25, 2021

negz commented Mar 26, 2021 • edited Loading

zzxwill commented Apr 5, 2021

zzxwill commented Apr 5, 2021

negz commented Apr 5, 2021

zzxwill commented Apr 6, 2021

zzxwill commented Apr 6, 2021

negz left a comment

Choose a reason for hiding this comment

zzxwill commented Mar 10, 2021 •

edited

Loading

negz commented Mar 26, 2021 •

edited

Loading