fix(environment): Validate against correct patch types

[MisterMX]

This validates the given environment patch types against the correct types as specified in the API.

Originally, only the *EnvironmentFieldPath types were accepted but the input API definition only defines *CompositeFieldPath patches:

function-patch-and-transform/input/v1beta1/resources_patches.go

Line 71 in 11be501

// +kubebuilder:validation:Enum=FromCompositeFieldPath;ToCompositeFieldPath;CombineFromComposite;CombineToComposite

[phisco]

Good catch! 🙏

[negz]

@MisterMX Looks like this needs a small unit test update too.

[MisterMX]

Thanks for the hint. I fixed the tests. To accomplish that I had to make some small changes to the render code:

Using the correct patch types requires changing the order in which xr and env are passed to ApplyToObjects to the "correct" order (xr, env) instead of (env, xr). Here env takes over the role of the composed resource just like in Apply.

Also, the tests were incorrectly assuming the environment data in patches to be under data which is not the case in Crossplane (see https://github.com/crossplane/crossplane/blob/806f0d20d146f6f4f1735c5ec6a7dc78923814b3/internal/controller/apiextensions/composite/environment_fetcher.go#L106). There it is not required to prefix environment patches with data. I changed that and remove the prefix from the tests.

[phisco]

Thanks again! 🙏