modified Dockerfile source images to use smaller base images #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Wadsworth <[email protected]>
bradkwadsworth-mw
force-pushed
the
feature/smaller-image
branch
from
90d3d6c to
44c9c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Recently I've been wanting to follow this method https://github.com/crossplane-contrib/function-kcl?tab=readme-ov-file#use-as-a-base-image for building custom Crossplane functions that includes schemas of the managed resources. With this workflow, a container will need to be built per composition. While I don't have an issue with this, the base image being 383MB is a little on the large side. This PR changes the base images in the Dockerfile and shrinks the golang binary using ldflags causing the new image size to be 156MB.
I have:
- [ ] Added or updated unit tests for my change.