Fix typo in 'metadata' #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Cope <[email protected]>
negz
commented
Aug 8, 2024
| @@ -240,7 +240,7 @@ spec: | |||
| } | |||
| ``` | |||
|
|
|||
| > Note that when returning multiple resources, we need to set different `metadata.name` or `matadata.annotations."krm.kcl.dev/composition-resource-name" ` to distinguish between different resources in the composition functions. | |||
| > Note that when returning multiple resources, we need to set different `metadata.name` or `metadata.annotations."krm.kcl.dev/composition-resource-name" ` to distinguish between different resources in the composition functions. | |||
There was a problem hiding this comment.
Is this really true?
At the Crossplane end, what matters is that the composition-resource-name is unique. It's fine for two different composed resources to have the same metadata.name, as long as they're of different types.
|
Good Catch! LGTM! If the user sets the same resource name, the implementation logic before is that function-kcl will overwrite/merge dup resources. After PR #126, it will check the uniqueness of the resource name at the function level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I noticed this typo in an error while experimenting with the function.
I have: