Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and examples #8

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

negz
Copy link
Member

@negz negz commented Nov 2, 2023

Description of your changes

This PR refactors the README to add a little more documentation on how to use the function. It also tries to match the README style of the other composition functions.

I've also broken the examples out into two directories. The Inline example can be rendered using the Crossplane CLI. I've simplified that one a bit to streamline doing that. The FileSystem example can't, so I've left it as it was.

I have:

This commit refactors the README to add a little more documentation on
how to use the function. It also tries to match the README style of the
other composition functions.

I've also broken the examples out into two directories. The Inline
example can be rendered using the Crossplane CLI. I've simplified that
one a bit to streamline doing that. The FileSystem example can't, so I've
left it as it was.

Signed-off-by: Nic Cope <[email protected]>
@negz negz requested review from ezgidemirel and turkenh November 2, 2023 04:42
Copy link
Collaborator

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@negz negz merged commit 5dbf5b2 into crossplane-contrib:main Nov 2, 2023
6 checks passed
@negz negz deleted the release-prep branch November 2, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants