Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sdk v0.3.0 and v1 proto #144

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

stevendborrelli
Copy link
Contributor

@stevendborrelli stevendborrelli commented Nov 23, 2024

Description of your changes

  • Update to function-sdk-go:v0.3.0
  • Update to crossplane-runtime v1.17.0
  • Update imports to v1 protoBuf definitions from v1beta1
  • Update tests to include new Target
  • Update golangci-lint to 1.62.0
  • Update go to 1.23.3

Fixes #135

Note that Crossplane-runtime v1.18.0 causes some breaking changes with function-sdk-go, which is why this PR only covers the upgrade to 1.17.0.

I have:

Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
@phisco
Copy link
Collaborator

phisco commented Nov 26, 2024

🤔 functions were promoted to v1 in 1.17, so, if we bump to v1 will this work with Crossplane 1.16 which is supported until Feb 2025? should we hold back the upgrade to v1 until then or at least set the xp constraint in the meta package?

@jbw976
Copy link
Member

jbw976 commented Nov 26, 2024

@phisco I think that is handled under the covers by the SDK Serve() setting up a beta server as well and translating between the two:
https://github.com/crossplane/function-sdk-go/blob/main/sdk.go#L158

Added in crossplane/function-sdk-go#155

@phisco
Copy link
Collaborator

phisco commented Nov 26, 2024

You are right, @jbw976, forgot about the automagic conversion 🎉 then LGTM!

@phisco phisco merged commit 6250ace into crossplane-contrib:main Nov 26, 2024
6 checks passed
@AbrohamLincoln AbrohamLincoln mentioned this pull request Nov 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go
4 participants