Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output envconfig name if missing instead of generic extra resource name #59

Conversation

stefnans
Copy link
Contributor

@stefnans stefnans commented Dec 5, 2024

Display the envconfig name in case it's missing

Executing

$ crossplane render --extra-resources example/environmentConfigs.yaml --include-context example/xr.yaml example/composition.yaml example/functions.yaml

Will output the name of the missing envconfig in the error message:

crossplane: error: cannot render composite resource: pipeline step "environmentConfigs" returned a fatal result: cannot get selected environment configs: Required environment config "missing-envconfig" not found

instead of

crossplane: error: cannot render composite resource: pipeline step "environmentConfigs" returned a fatal result: cannot get selected environment configs: Required environment config "environment-config-0" not found

Fixes #60

I have:

@phisco
Copy link
Collaborator

phisco commented Dec 6, 2024

Thanks, @stefnans! Sounds reasonable!

@phisco phisco merged commit 90c5b4e into crossplane-contrib:main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the error message in case of missing environment config
2 participants