docs: migration from native composition environment #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tampakrap
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Very nice, thank you for providing it! I submitted some 💅 and minor suggestions. I have two extra suggestions:
- How about adding a ToC at the top
- Maybe to move the Migration section lower in the document, possibly between the Using and Developing sections
The content looks good though, thank you!
|
and another suggestion would be to put somewhere the link to the official doc https://docs.crossplane.io/latest/concepts/environment-configs/ I'm not sure what would be the best place, maybe an extra section or maybe just a phrase in the |
Signed-off-by: Philippe Scorsolini <[email protected]>
Signed-off-by: Philippe Scorsolini <[email protected]>
jbw976
reviewed
Oct 15, 2024
|
|
||
| ## Migration from native Composition Environment | ||
|
|
||
| Crossplane 1.8 [dropped] native Composition Environment, meaning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #43
Follow up to crossplane/crossplane#5938, already mentioning the
crossplane beta convert pipeline-compositionwhich still has to be implemented.I have:
Added or updated unit tests for my change.