channel: use AtomicUsize::get_mut in flavors::{array,list}::Channel::drop
#811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As access to `&mut self` in `Drop` impls gives exclusive access, it's unnecessary to atomically load `self.head` and `self.tail` there.
|
I stumbled across this as I was reading the code for educational purposes |
eb-64-64
changed the title
AtomicUsize::get_mut in flavors::array::Channel::dropAtomicUsize::get_mut in flavors::array::Channel::drop
eb-64-64
changed the title
AtomicUsize::get_mut in flavors::array::Channel::dropAtomicUsize::get_mut in flavors::{array,list}::Channel::drop
|
Thanks! I'll merge this once the upstream bugfix (rust-lang/rust#95621) which fixes the breakage on miri CI merged. |
|
You could temporarily remove the |
|
Thanks for the advice. This time I chose to wait for the patch to be merged since it had already been submitted that looked reasonable. It makes sense to temporarily remove the flag if the fix is going to take a long time. |
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2022
874: Use get_mut instead of atomic load in Drop impls r=taiki-e a=taiki-e Similar to #811, but for deque and queue. Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As access to
&mut selfinDropimpls gives exclusive access, it'sunnecessary to atomically load
self.headandself.tailthere.