Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Commit

Permalink
Removed String monkey patch
Browse files Browse the repository at this point in the history
We hit this issue in production: caseyhoward#8

Seeing as the monkey patch is not used internally and we don't use it
either, the best course of action seemed to be removing it.
  • Loading branch information
gshutler committed Aug 20, 2015
1 parent a184e47 commit 226395c
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 33 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
source 'http://rubygems.org'
source 'https://rubygems.org'

gemspec
13 changes: 10 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
PATH
remote: .
specs:
nokogiri-plist (0.4.1)
nokogiri-plist (0.5.0)
nokogiri

GEM
remote: http://rubygems.org/
remote: https://rubygems.org/
specs:
mini_portile (0.6.2)
mocha (0.9.12)
nokogiri (1.4.4)
nokogiri (1.6.6.2)
mini_portile (~> 0.6.0)
rake (0.9.6)
shoulda (2.11.3)

PLATFORMS
Expand All @@ -17,4 +20,8 @@ PLATFORMS
DEPENDENCIES
mocha
nokogiri-plist!
rake
shoulda

BUNDLED WITH
1.10.6
1 change: 0 additions & 1 deletion Rakefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
require 'rake/testtask'

Rake::TestTask.new :test do |t|
require 'redgreen' if Gem.available?('redgreen')
t.libs << 'lib'
t.pattern = 'test/**/test_*.rb'
t.verbose = true
Expand Down
7 changes: 0 additions & 7 deletions lib/core_ext/string.rb

This file was deleted.

4 changes: 1 addition & 3 deletions lib/nokogiri-plist.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,4 @@
require 'nokogiri-plist/node'
require 'nokogiri-plist/plist'

require 'core_ext/string'

Nokogiri::XML::Node.send :include, NokogiriPList::Node
Nokogiri::XML::Node.send :include, NokogiriPList::Node
3 changes: 2 additions & 1 deletion nokogiri-plist.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ Gem::Specification.new do |s|

s.required_rubygems_version = ">= 1.3.6"

s.add_development_dependency 'shoulda'
s.add_development_dependency 'mocha'
s.add_development_dependency 'rake'
s.add_development_dependency 'shoulda'

s.add_dependency 'nokogiri'

Expand Down
2 changes: 1 addition & 1 deletion test/nokogiri-plist/test_generator.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'test/test_helper'
require_relative '../test_helper'

class NokogiriPList::GeneratorTest < Test::Unit::TestCase

Expand Down
2 changes: 1 addition & 1 deletion test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
ROOT = File.join(File.expand_path(File.dirname(__FILE__)), '..')

$LOAD_PATH.unshift(ROOT)
require File.join('nokogiri-plist.rb')
require File.join('nokogiri-plist.rb')
15 changes: 0 additions & 15 deletions test/test_string.rb

This file was deleted.

0 comments on commit 226395c

Please sign in to comment.