Handle cases where the domain is undefined

croct-tech · Jul 22, 2020 · bf25513 · bf25513
1 parent 34b14b5
commit bf25513
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/cookie.ts b/src/cookie.ts
@@ -1,4 +1,4 @@
-export function getBaseDomain(domain = window.document.domain): string {
+export function getBaseDomain(domain = window.document.domain ?? ''): string {
     const parts: string[] = domain.split('.');
     const random = `___${Math.random()}`;
 

diff --git a/test/cookie.test.ts b/test/cookie.test.ts
@@ -15,6 +15,11 @@ beforeEach(() => {
 });
 
 describe('A function to detect the base domain', () => {
+    test('should not fail if the domain is undefined', () => {
+        expect(document.domain).toBeUndefined();
+        expect(getBaseDomain()).toBe('');
+    });
+
     test('should detect the top-most domain that allows for setting cookies', () => {
         let cookie = '';
         cookieSetter.mockImplementation(value => {