Skip to content

Commit

Permalink
Replace package version with the tag name before running rollup
Browse files Browse the repository at this point in the history
Prior to this change, the version was replaced only for publishing on NPM. This resulted in compiled bundles with the `0.0.0-dev` version in the metadata instead of the new release version.
  • Loading branch information
Fryuni authored Mar 24, 2020
1 parent 46e4e10 commit 9a1c884
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy-published-releases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ jobs:

- name: Build bundles
run: |-
node_modules/.bin/rollup -c rollup.config.js \
sed -i -e "s~\"version\": \"0.0.0-dev\"~\"version\": \"${GITHUB_REF##*/}\"~" package.json
npx rollup -c rollup.config.js \
--config-bootstrap-endpoint ${BOOTSTRAP_ENDPOINT} \
--config-tracker-endpoint ${TRACKER_ENDPOINT} \
--config-evaluation-endpoint ${EVALUATION_ENDPOINT}
rm -r build/declarations
sed -i -e "s~\"version\": \"0.0.0-dev\"~\"version\": \"${GITHUB_REF##*/}\"~" package.json
- name: Upload artifacts
uses: actions/upload-artifact@v1
Expand Down

0 comments on commit 9a1c884

Please sign in to comment.