Fix incorrect timeout log on evaluate requests (#442)

croct-tech · Dec 5, 2024 · 8db161a · 8db161a
1 parent 83fad07
commit 8db161a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/evaluator.ts b/src/evaluator.ts
@@ -170,7 +170,7 @@ export class Evaluator {
             let timer: number | NodeJS.Timeout | undefined;
 
             if (timeout !== undefined) {
-                setTimeout(
+                timer = setTimeout(
                     () => {
                         const response: ErrorResponse = {
                             title: `Evaluation could not be completed in time for query "${reference}".`,

diff --git a/test/evaluator.test.ts b/test/evaluator.test.ts
@@ -351,6 +351,8 @@ describe('An evaluator', () => {
 
         await expect(evaluator.evaluate(query, {timeout: 10})).resolves.toBe('Carol');
 
+        jest.advanceTimersByTime(11);
+
         expect(logger.error).not.toHaveBeenCalled();
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -351,6 +351,8 @@ describe('An evaluator', () => { @@
             await expect(evaluator.evaluate(query, {timeout: 10})).resolves.toBe('Carol');
+            jest.advanceTimersByTime(11);
             expect(logger.error).not.toHaveBeenCalled();
         });
@@ Expand Down @@