-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bump stable packages - abandoned #201
Conversation
6918886
0ec6ba6
to
6918886
Compare
27f31f0
6918886
to
27f31f0
Compare
32283dd
27f31f0
to
32283dd
Compare
ad02c06
32283dd
to
ad02c06
Compare
45a61ed
ad02c06
to
45a61ed
Compare
42a1fc6
07efb41
to
42a1fc6
Compare
9b26270
42a1fc6
to
9b26270
Compare
171d821
9b26270
to
171d821
Compare
…ocked from scratch between tests
f31bfd9
jest.restoreAllMocks(); | ||
jest.clearAllMocks(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I choose to use restore over reset because the reset replaces the mock with an empty function that return undefined, leading some tests to errors since we are mocking the window.removeEventListener
and window.addEventListener
, on the other hand, the restore will restore the original function, and since we are spying the window again in the beforeEach
, I see no problem.
The clearAllMocks
is here because the restoreMock
restore only jest.spyOn
mocks, so the clear will deal with jest.fn()
mocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearAllMocks
clears the call history for every mock. Good.
resetAllMocks
calls clearAllMocks
plus replaces the mock implementation with a function returning undefined. If that is the problematic behavior, we should replace the call with just clearAllMocks
.
restoreAllMocks
removes the mock. After this call, all mocks that can be restored are no longer mocked. This might open up potential flaky tests, regressions, and false negatives since we no longer mock the situation we want to test. If there is a test after this call validating that internal errors are not propagated, for example, it would become a non-error scenario, and the code would no longer be tested.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
jest.restoreAllMocks(); | ||
jest.clearAllMocks(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearAllMocks
clears the call history for every mock. Good.
resetAllMocks
calls clearAllMocks
plus replaces the mock implementation with a function returning undefined. If that is the problematic behavior, we should replace the call with just clearAllMocks
.
restoreAllMocks
removes the mock. After this call, all mocks that can be restored are no longer mocked. This might open up potential flaky tests, regressions, and false negatives since we no longer mock the situation we want to test. If there is a test after this call validating that internal errors are not propagated, for example, it would become a non-error scenario, and the code would no longer be tested.
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
2.0.1
->2.1.0
1.37.1
->1.39.0
25.0.4
->25.0.7
15.2.0
->15.2.3
5.0.2
->5.0.4
11.1.2
->11.1.5
29.5.3
->29.5.6
29.6.2
->29.7.0
29.6.2
->29.7.0
2.9.3
->2.10.0
3.28.0
->3.29.4
5.1.6
->5.2.2
Release Notes
croct-tech/json-js (@croct/json)
v2.1.0
Compare Source
What's Changed
🚀 Features
🔧 Enhancements
🚧 Maintenance
🎉 Thanks to all contributors helping with this release:
@Fryuni, @renovate and @renovate[bot]
microsoft/playwright (@playwright/test)
v1.39.0
Compare Source
Add custom matchers to your expect
You can extend Playwright assertions by providing custom matchers. These matchers will be available on the expect object.
See the documentation for a full example.
Merge test fixtures
You can now merge test fixtures from multiple files or modules:
Merge custom expect matchers
You can now merge custom expect matchers from multiple files or modules:
Hide implementation details: box test steps
You can mark a
test.step()
as "boxed" so that errors inside it point to the step call site.Error: Timed out 5000ms waiting for expect(locator).toBeVisible() ... error details omitted ... 14 | await page.goto('https://github.com/login'); > 15 | await login(page); | ^ 16 | });
See
test.step()
documentation for a full example.New APIs
expect(locator).toHaveAttribute(name)
Browser Versions
This version was also tested against the following stable channels:
v1.38.1
Compare Source
Highlights
https://github.com/microsoft/playwright/issues/27071 - expect(value).toMatchSnapshot() deprecation announcement on V1.38
https://github.com/microsoft/playwright/issues/27072 - [BUG] PWT trace viewer fails to load trace and throws TypeErrorhttps://github.com/microsoft/playwright/issues/270733 - [BUG] RangeError: Invalid time valuhttps://github.com/microsoft/playwright/issues/2708787 - [REGRESSION]: npx playwright test --list prints all tests twihttps://github.com/microsoft/playwright/issues/27113113 - [REGRESSION]: No longer able to extend PlaywrightTest.Matchers type for locators and pahttps://github.com/microsoft/playwright/issues/271447144 - [BUG]can not display thttps://github.com/microsoft/playwright/issues/2716327163 - [REGRESSION] Single Quote Wrongly Escaped by Locator When Using Unicodehttps://github.com/microsoft/playwright/issues/27181/27181 - [BUG] evaluate serializing fails at 1.38
Browser Versions
This version was also tested against the following stable channels:
v1.38.0
Compare Source
UI Mode Updates
New APIs
browserContext.on('weberror')
][browserContext.on('weberror')]locator.pressSequentially()
][locator.pressSequentially()]reporter.onEnd()
][reporter.onEnd()] now reportsstartTime
and total runduration
.Deprecations
page.type()
][page.type()], [frame.type()
][frame.type()], [locator.type()
][locator.type()] and [elementHandle.type()
][elementHandle.type()].Please use [
locator.fill()
][locator.fill()] instead which is much faster. Use [locator.pressSequentially()
][locator.pressSequentially()] only if there is aspecial keyboard handling on the page, and you need to press keys one-by-one.
Breaking Changes: Playwright no longer downloads browsers automatically
Playwright recommends to use
@playwright/test
package and download browsers vianpx playwright install
command. If you are following this recommendation, nothing has changed for you.However, up to v1.38, installing the
playwright
package instead of@playwright/test
did automatically download browsers. This is no longer the case, and we recommend to explicitly download browsers vianpx playwright install
command.v1.37 and earlier
playwright
package was downloading browsers duringnpm install
, while@playwright/test
was not.v1.38 and later
playwright
and@playwright/test
packages do not download browsers duringnpm install
.Recommended migration
Run
npx playwright install
to download browsers afternpm install
. For example, in your CI configuration:Alternative migration option - not recommended
Add
@playwright/browser-chromium
,@playwright/browser-firefox
and@playwright/browser-webkit
as a dependency. These packages download respective browsers duringnpm install
. Make sure you keep the version of all playwright packages in sync:Browser Versions
This version was also tested against the following stable channels:
rollup/plugins (@rollup/plugin-commonjs)
v25.0.7
Compare Source
2023-10-15
Bugfixes
v25.0.6
Compare Source
2023-10-15
Bugfixes
v25.0.5
Compare Source
2023-10-05
Bugfixes
rollup/plugins (@rollup/plugin-node-resolve)
v15.2.3
Compare Source
2023-10-08
Bugfixes
v15.2.2
Compare Source
2023-10-05
Bugfixes
v15.2.1
Compare Source
2023-08-22
Bugfixes
rollup/plugins (@rollup/plugin-replace)
v5.0.4
Compare Source
2023-10-15
Bugfixes
v5.0.3
Compare Source
2023-10-05
Bugfixes
rollup/plugins (@rollup/plugin-typescript)
v11.1.5
Compare Source
2023-10-05
Bugfixes
v11.1.4
Compare Source
2023-09-25
Bugfixes
v11.1.3
Compare Source
2023-08-26
Bugfixes
jestjs/jest (jest)
v29.7.0
Compare Source
Features
[create-jest]
Addnpm init
/yarn create
initialiser for Jest projects (#14465)[jest-validate]
Allow deprecation warnings for unknown options (#14499)Fixes
[jest-resolver]
Replace unmatched capture groups inmoduleNameMapper
with empty string instead ofundefined
(#14507)[jest-snapshot]
Allow for strings as well as template literals in inline snapshots (#14465)[@jest/test-sequencer]
Calculate test runtime ifperStats.duration
is missing (#14473)Performance
[@jest/create-cache-key-function]
Cache access ofNODE_ENV
andBABEL_ENV
(#14455)Chore & Maintenance
[jest-cli]
Move internal config initialisation logic to thecreate-jest
package (#14465)v29.6.4
Compare Source
Fixes
[jest-core]
Fix typo inscheduleAndRun
performance marker (#14434)[jest-environment-node]
Make sureatob
andbtoa
are writeable in Node 20 (#14446)[jest-worker]
Additional error wrapper forparentPort.postMessage
to fix unhandledDataCloneError
. (#14437)v29.6.3
Compare Source
Fixes
[expect, @​jest/expect-utils]
ObjectContaining
supportsumbol
as key (#14414)[expect]
Remove@types/node
from dependencies (#14385)[jest-core]
Use workers in watch mode by default to avoid crashes (#14059 & #14085).[jest-reporters]
Updateistanbul-lib-instrument
dependency to v6. (#14401)[jest-mock]
Revert #13692 as it was a breaking change (#14429)[jest-mock]
Revert #13866 as it was a breaking change (#14429)[jest-mock]
Revert #13867 as it was a breaking change (#14429)[@jest/reporters]
Marks Reporter's hooks as optional (#14433)[jest-runtime]
Fix dynamic ESM import module bug when loaded module throughjest.isolateModulesAsync
(#14397)Chore & Maintenance
[jest-changed-files, jest-circus, jest-console, @​jest/core, @​jest/runtime, @​jest/transform]
Useinvariant
andnotEmpty
fromjest-util
rather than own internal (#14366)parcel-bundler/parcel (parcel)
v2.10.0
Compare Source
Added
Core
--lazy
mode – Details, Details@babel/register
,esbuild-register
,ts-node
) – DetailsBundler
Resolver
JavaScript
globalThis
polyfill for old browsers – DetailsCSS
WASM
XML
Web Extensions
Web Manifest
Fixed
Core
--lazy
mode bugs – DetailsJavaScript
Bundler
Images
Sass
Dev Server
Unstable
Core
Bundler
JavaScript
rollup/rollup (rollup)
v3.29.4
Compare Source
2023-09-28
Bug Fixes
Pull Requests
v3.29.3
Compare Source
2023-09-24
Bug Fixes
Pull Requests
v3.29.2
Compare Source
2023-09-15
Bug Fixes
TreeshakingPreset
type (#5131)Pull Requests
TreeshakingPreset
(@moltar)v3.29.1
Compare Source
2023-09-10
Bug Fixes
Pull Requests
v3.29.0
Compare Source
2023-09-06
Features
api
to Plugin type (#5112)Bug Fixes
Pull Requests
v3.28.1
Compare Source
2023-08-22
Bug Fixes
Pull Requests
Microsoft/TypeScript (typescript)
v5.2.2
: TypeScript 5.2Compare Source
For release notes, check out the release announcement.
For the complete list of fixed issues, check out the
Downloads are available on:
Configuration
📅 Schedule: Branch creation - "before 4am every weekday" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.