Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the generated zip archives and include individual certs #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zacikpa
Copy link
Contributor

@zacikpa zacikpa commented Oct 3, 2021

Currently, we export each chain as a single file chain.pem together with the root cert root.pem. This makes it hard to validate manually using command-line OpenSSL, since it only accepts a single cert per file.

This PR flattens the archive structure (no subdirectories as is the case now) and also exports each certificate separately.

An example archive may look like this:

  • EXPIRED
    - chain.pem (contains endpoint and two intermediate CA certs)
    - root.pem
    - endpoint.pem
    - intermediate1.pem
    - intermediate2.pem

Solves #104.

Copy link
Member

@mukrop mukrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions before approval:

  • Is generating a chain file and then splitting it not too complicated? Did you not consider adjusting the generating scripts to create individual files? Then, the chain can be easily created by concatenation of cert files (possibly even directly in Make). I know this would introduce more changes (all generating scripts would need to be changed), but I find it a more modular design (with fewer utility scripts).
  • (Only relevant if the previous question is dismissed.) Your Makefile changes hardcode the folder name tmp on multiple places. I'd prefer having it as a variable. Similarly, the new utility script hardcodes the names endpoint.pem and intermediate[num].pem – this may be OK, though I was hesitant if hardcoding the names will not cause trouble later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export the ZIP archives so they can be easily validated using openssl too
2 participants